Re: [PATCH] net: ocelot: Add of_node_put() before return statement

From: David Miller
Date: Mon Aug 24 2020 - 21:04:45 EST


From: Sumera Priyadarsini <sylphrenadin@xxxxxxxxx>
Date: Sun, 23 Aug 2020 19:22:45 +0530

> Every iteration of for_each_available_child_of_node() decrements
> the reference count of the previous node, however when control
> is transferred from the middle of the loop, as in the case of
> a return or break or goto, there is no decrement thus ultimately
> resulting in a memory leak.
>
> Fix a potential memory leak in felix.c by inserting of_node_put()
> before the return statement.
>
> Issue found with Coccinelle.
>
> Signed-off-by: Sumera Priyadarsini <sylphrenadin@xxxxxxxxx>

Applied.