Re: [kbuild-all] Re: drivers/greybus/es2.c:439 message_send() error: double unlocked 'es2->cport_out_urb_lock' (orig line 417)

[Johan Hovold]

On Tue, Aug 25, 2020 at 02:37:04AM +0000, Xia, Hui wrote:
> >-----Original Message-----
> >From: Johan Hovold <johan@xxxxxxxxxx>
> >Sent: 2020年8月24日 17:54
> >To: kernel test robot <lkp@xxxxxxxxx>
> >Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; kbuild-all@xxxxxxxxxxxx;
> >linux-kernel@xxxxxxxxxxxxxxx
> >Subject: [kbuild-all] Re: drivers/greybus/es2.c:439 message_send() error: double
> >unlocked 'es2->cport_out_urb_lock' (orig line 417)
> >
> >On Fri, Aug 14, 2020 at 03:26:27AM +0800, kernel test robot wrote:
> >> Hi Greg,
> >>
> >> First bad commit (maybe != root cause):
> >>
> >> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> >> head:   dc06fe51d26efc100ac74121607c01a454867c91
> >> commit: b81beec9cb2d586412c7166c893894930f19965e staging: greybus:
> >move es2 to drivers/greybus/
> >> date:   12 months ago
> >> config: x86_64-randconfig-m001-20200813 (attached as .config)
> >> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
> >>
> >> If you fix the issue, kindly add following tag as appropriate
> >> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> >>
> >> New smatch warnings:
> >> drivers/greybus/es2.c:439 message_send() error: double unlocked
> >> 'es2->cport_out_urb_lock' (orig line 417)
> >> drivers/greybus/es2.c:879 cport_out_callback() error: double unlocked
> >> 'es2->cport_out_urb_lock' (orig line 871)
> >> drivers/greybus/es2.c:1018 arpc_sync() error: double unlocked
> >> 'es2->arpc_lock' (orig line 992)
> >>
> >> Old smatch warnings:
> >> drivers/greybus/es2.c:441 message_send() error: double unlocked
> >> 'es2->cport_out_urb_lock' (orig line 439)
> >
> >None of these warnings make any sense. Is the robot drunk?

> It is a false positive. Please kindly ignore.
> There was a bug in robot that sent unconfident reports out directly
> and has been fixed. Sorry for inconvenient.

Ok, thanks for confirming.

Johan