Re: [PATCH v1 1/1] extcon: ptn5150: Add usb-typec support for Intel LGM SoC
From: Krzysztof Kozlowski
Date: Tue Aug 25 2020 - 04:41:00 EST
On Tue, Aug 25, 2020 at 04:31:47PM +0800, Ramuthevar,Vadivel MuruganX wrote:
> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@xxxxxxxxxxxxxxx>
>
> Add usb-typec detection support for Intel LGM SoC based
> boards.
>
> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@xxxxxxxxxxxxxxx>
> ---
> drivers/extcon/extcon-ptn5150.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c
> index 8ba706fad887..60355a1b5cb2 100644
> --- a/drivers/extcon/extcon-ptn5150.c
> +++ b/drivers/extcon/extcon-ptn5150.c
> @@ -300,6 +300,8 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c)
> return ret;
> }
>
> + extcon_set_property_capability(info->edev, EXTCON_USB_HOST,
> + EXTCON_PROP_USB_TYPEC_POLARITY);
Hi,
I think you need the same for EXTCON_USB.
Although extcon_set_property_capability() error should not be fatal, but
printing a warn message would be useful.
Best regards,
Krzysztof
> /* Initialize PTN5150 device and print vendor id and version id */
> ret = ptn5150_init_dev_type(info);
> if (ret)
> --
> 2.11.0
>