Re: [PATCH v2] kobject: Restore old behaviour of kobject_del(NULL)
From: Greg Kroah-Hartman
Date: Tue Aug 25 2020 - 11:45:50 EST
On Tue, Aug 25, 2020 at 05:41:09PM +0300, Andy Shevchenko wrote:
> On Mon, Aug 03, 2020 at 11:46:59AM +0200, Greg Kroah-Hartman wrote:
> > On Mon, Aug 03, 2020 at 11:27:06AM +0300, Andy Shevchenko wrote:
> > > The commit 079ad2fb4bf9 ("kobject: Avoid premature parent object freeing in
> > > kobject_cleanup()") inadvertently dropped a possibility to call kobject_del()
> > > with NULL pointer. Restore the old behaviour.
> > >
> > > Fixes: 079ad2fb4bf9 ("kobject: Avoid premature parent object freeing in kobject_cleanup()")
> > > Reported-by: Qu Wenruo <quwenruo.btrfs@xxxxxxx>
> > > Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > > ---
> > > v2: replaced ?: with plain conditional (Greg)
> > > lib/kobject.c | 6 +++++-
> > > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > Thanks, much better, will queue up after -rc1 is out.
>
> Shouldn't be this taken care of?
Yes, will get to it soon, after -rc1 is tough, combined with Plumbers...
greg k-h