RE: [PATCH 1/1] dt-bindings: riscv: sifive-l2-cache: convert bindings to json-schema

From: Sagar Kadam
Date: Tue Aug 25 2020 - 12:41:59 EST


Hi Rob,

> -----Original Message-----
> From: Rob Herring <robh@xxxxxxxxxx>
> Sent: Tuesday, August 25, 2020 9:51 PM
> To: Sagar Kadam <sagar.kadam@xxxxxxxxxxxx>
> Cc: aou@xxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Paul Walmsley (
> Sifive) <paul.walmsley@xxxxxxxxxx>; Yash Shah <yash.shah@xxxxxxxxxxxx>;
> palmer@xxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> riscv@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/1] dt-bindings: riscv: sifive-l2-cache: convert bindings
> to json-schema
>
> [External Email] Do not click links or attachments unless you recognize the
> sender and know the content is safe
>
> On Tue, Aug 25, 2020 at 2:47 AM Sagar Kadam
> <sagar.kadam@xxxxxxxxxxxx> wrote:
> >
> > Hello Rob,
> >
> > > -----Original Message-----
> > > From: Rob Herring <robh@xxxxxxxxxx>
> > > Sent: Monday, August 24, 2020 11:06 PM
> > > To: Sagar Kadam <sagar.kadam@xxxxxxxxxxxx>
> > > Cc: aou@xxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Paul Walmsley
> > > (
> > > Sifive) <paul.walmsley@xxxxxxxxxx>; robh+dt@xxxxxxxxxx; Yash Shah
> > > <yash.shah@xxxxxxxxxxxx>; palmer@xxxxxxxxxxx; linux-
> > > kernel@xxxxxxxxxxxxxxx; linux-riscv@xxxxxxxxxxxxxxxxxxx
> > > Subject: Re: [PATCH 1/1] dt-bindings: riscv: sifive-l2-cache:
> > > convert bindings to json-schema
> > >
> > > [External Email] Do not click links or attachments unless you
> > > recognize the sender and know the content is safe
> > >
> > > On Mon, 24 Aug 2020 13:20:21 +0530, Sagar Kadam wrote:
> > > > Convert the device tree bindings for the SiFive's FU540-C000 SoC's
> > > > L2 Cache controller to YAML format.
> > > >
> > > > Signed-off-by: Sagar Kadam <sagar.kadam@xxxxxxxxxx>
> > > > ---
> > > > .../devicetree/bindings/riscv/sifive-l2-cache.txt | 51
> > > > ------------ .../devicetree/bindings/riscv/sifive-l2-cache.yaml |
> > > > 93
> > > > ++++++++++++++++++++++
> > > > 2 files changed, 93 insertions(+), 51 deletions(-) delete mode
> > > > 100644 Documentation/devicetree/bindings/riscv/sifive-l2-cache.txt
> > > > create mode 100644
> > > > Documentation/devicetree/bindings/riscv/sifive-l2-cache.yaml
> > > >
> > >
> > >
> > > My bot found errors running 'make dt_binding_check' on your patch:
> > >
> >
> > I had checked using DT_SCHEMA_FILES option due to which it didn't
> > catch any error on other schemas. Without this I could regenerate the
> error you mentioned.
> > I will fix it and update. Sorry for the error.
>
> Update your kernel. DT_SCHEMA_FILES setting no longer matters on current
> tree. It only affects 'dtbs_check' now.
>

Thanks for the input.
Sure, I see v5.9-rc2 as latest tag on mainline, I will base and fix my patch above it.

BR,
Sagar

> Rob