Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: add initial trogdor and lazor dt

[Doug Anderson]

Hi,

On Tue, Aug 25, 2020 at 3:22 PM Rob Clark <robdclark@xxxxxxxxx> wrote:
>
> On Tue, Aug 25, 2020 at 2:21 AM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:
> >
> > Quoting Rob Clark (2020-08-24 17:33:39)
> > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> > > new file mode 100644
> > > index 000000000000..b04987ab6c22
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> > > @@ -0,0 +1,1364 @@
> > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > +/*
> > [...]
> > > +
> > > +       gpio_keys: gpio-keys {
> > > +               compatible = "gpio-keys";
> > > +               status = "disabled";
> > > +               pinctrl-names = "default";
> > > +               pinctrl-0 = <&pen_pdct_l>;
> > > +
> > > +               pen-insert {
> > > +                       label = "Pen Insert";
> > > +
> > > +                       /* Insert = low, eject = high */
> > > +                       gpios = <&tlmm 52 GPIO_ACTIVE_LOW>;
> > > +                       linux,code = <SW_PEN_INSERTED>;
> > > +                       linux,input-type = <EV_SW>;
> > > +                       wakeup-source;
> > > +               };
> > > +       };
> > > +
> > > +       max98357a: max98357a {
> >
> > Maybe node name should be 'audio-codec' or 'dac' or 'amp' or 'speaker'
> > or 'codec'?
>
> looking at other boards, it looks like 2 votes for "audio-codec-0",
> one vote for "codec0", and 2 votes for "max98357a"..  so seems to be a
> codec rather than amp/speaker.. and "audio-codec" seems to be the
> popular choice..

I'd look at recently landed yaml files under
"Documentation/devicetree/bindings/sound/".  Those have the best
change of having been reviewed by Rob Herring.

Oh, or you could look at the Devicetree Spec [1]

2.2.2 Generic Names Recommendation
...
* audio-codec

[1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3