Re: [PATCH 09/11] soundwire: intel: add dynamic debug trace for clock-stop invalid configs

[Pierre-Louis Bossart]

On 8/26/20 4:48 AM, Vinod Koul wrote:
> On 18-08-20, 10:41, Bard Liao wrote:
> > From: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
> >
> > Detect cases where the clock is assumed to be stopped but the IP is
> > not in the relevant state, and add a dynamic debug trace.
>
> you meant a debug print..and it looks like error print below (also in title).

I don't understand the comment. Is the 'trace' confusing and are you 
asking to e.g. change the commit message to 'add dynamic debug log'?

> > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
> > Signed-off-by: Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx>
> > ---
> >   drivers/soundwire/intel.c | 5 +++++
> >   1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
> > index 7c63581270fd..b82d02af3c4f 100644
> > --- a/drivers/soundwire/intel.c
> > +++ b/drivers/soundwire/intel.c
> > @@ -1964,6 +1964,11 @@ static int intel_resume_runtime(struct device *dev)
> >   			}
> >   		}
> >   	} else if (!clock_stop_quirks) {
> > +
> > +		clock_stop0 = sdw_cdns_is_clock_stop(&sdw->cdns);
> > +		if (!clock_stop0)
> > +			dev_err(dev, "%s invalid configuration, clock was not stopped", __func__);
> > +
> >   		ret = intel_init(sdw);
> >   		if (ret) {
> >   			dev_err(dev, "%s failed: %d", __func__, ret);
> > --
> > 2.17.1