Re: [PATCH v1 4/9] powerpc/vdso: Remove unnecessary ifdefs in vdso_pagelist initialization

[Christophe Leroy]

Le 26/08/2020 à 16:58, Michael Ellerman a écrit :
> Christophe Leroy <christophe.leroy@xxxxxxxxxx> writes:
> > diff --git a/arch/powerpc/kernel/vdso.c b/arch/powerpc/kernel/vdso.c
> > index daef14a284a3..bbb69832fd46 100644
> > --- a/arch/powerpc/kernel/vdso.c
> > +++ b/arch/powerpc/kernel/vdso.c
> > @@ -718,16 +710,14 @@ static int __init vdso_init(void)
> ...
> >   
> > -
> > -#ifdef CONFIG_VDSO32
> >   	vdso32_kbase = &vdso32_start;
> >   
> >   	/*
> > @@ -735,8 +725,6 @@ static int __init vdso_init(void)
> >   	 */
> >   	vdso32_pages = (&vdso32_end - &vdso32_start) >> PAGE_SHIFT;
> >   	DBG("vdso32_kbase: %p, 0x%x pages\n", vdso32_kbase, vdso32_pages);
> > -#endif
>
> This didn't build for ppc64le:
>
>    /opt/cross/gcc-8.20_binutils-2.32/powerpc64-unknown-linux-gnu/bin/powerpc64-unknown-linux-gnu-ld: arch/powerpc/kernel/vdso.o:(.toc+0x0): undefined reference to `vdso32_end'
>    /opt/cross/gcc-8.20_binutils-2.32/powerpc64-unknown-linux-gnu/bin/powerpc64-unknown-linux-gnu-ld: arch/powerpc/kernel/vdso.o:(.toc+0x8): undefined reference to `vdso32_start'
>    make[1]: *** [/scratch/michael/build/maint/Makefile:1166: vmlinux] Error 1
>    make: *** [Makefile:185: __sub-make] Error 2
>
> So I just put that ifdef back.

Argh. I guess that's the DBG() that hurts. I'll think about it.

Christophe