Re: [PATCH v2] perf expr: Force encapsulation on expr_id_data

[Jiri Olsa]

On Wed, Aug 26, 2020 at 08:30:55AM -0700, Ian Rogers wrote:
> This patch resolves some undefined behavior where variables in
> expr_id_data were accessed (for debugging) without being defined. To
> better enforce the tagged union behavior, the struct is moved into
> expr.c and accessors provided. Tag values (kinds) are explicitly
> identified.
> 
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>

great, thanks for doing this

Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

jirka