Re: [PATCH 4/4] regmap: sdw: add support for SoundWire 1.2 MBQ

From: Pierre-Louis Bossart
Date: Wed Aug 26 2020 - 12:57:24 EST



+#include <linux/device.h>
+#include <linux/errno.h>
+#include <linux/mod_devicetable.h>

Curious why do you need this header?

I'll return the question back to you, since you added this header for regmap-sdw.c:

7c22ce6e21840 (Vinod Koul 2018-01-08 15:50:59 +0530 6) #include <linux/mod_devicetable.h>

so I assumed it was needed here as well.

+MODULE_DESCRIPTION("Regmap SoundWire Module");

This is same of sdw module, pls make this one a bit different.

yes, fixed.