Re: [PATCH 3/6] ARM: dts: broadcom: Fix SP804 node

[Florian Fainelli]

On 8/26/20 11:38 AM, Andre Przywara wrote:
> The DT binding for SP804 requires to have an "arm,primecell" compatible
> string.
> Add this string so that the Linux primecell bus driver picks the device
> up and activates the clock.
> 
> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>

The commit subject should be:

ARM: dts: NSP: Fix SP804 compatible node

and we should probably have a Fixes tag that is:

Fixes: a0efb0d28b77 ("ARM: dts: NSP: Add SP804 Support to DT")

Could you please re-submit with those things corrected? Thanks

> ---
>  arch/arm/boot/dts/bcm-nsp.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi
> index 0346ea621f0f..1333ef8be0a2 100644
> --- a/arch/arm/boot/dts/bcm-nsp.dtsi
> +++ b/arch/arm/boot/dts/bcm-nsp.dtsi
> @@ -368,7 +368,7 @@
>  		};
>  
>  		ccbtimer0: timer@34000 {
> -			compatible = "arm,sp804";
> +			compatible = "arm,sp804", "arm,primecell";
>  			reg = <0x34000 0x1000>;
>  			interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>,
>  				     <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
> 


-- 
Florian