Re: [PATCH v4 3/3] io_uring: allow disabling rings during the creation

From: Kees Cook
Date: Wed Aug 26 2020 - 15:50:45 EST


On Thu, Aug 13, 2020 at 05:32:54PM +0200, Stefano Garzarella wrote:
> This patch adds a new IORING_SETUP_R_DISABLED flag to start the
> rings disabled, allowing the user to register restrictions,
> buffers, files, before to start processing SQEs.
>
> When IORING_SETUP_R_DISABLED is set, SQE are not processed and
> SQPOLL kthread is not started.
>
> The restrictions registration are allowed only when the rings
> are disable to prevent concurrency issue while processing SQEs.
>
> The rings can be enabled using IORING_REGISTER_ENABLE_RINGS
> opcode with io_uring_register(2).
>
> Suggested-by: Jens Axboe <axboe@xxxxxxxxx>
> Signed-off-by: Stefano Garzarella <sgarzare@xxxxxxxxxx>

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

Where can I find the io_uring selftests? I'd expect an additional set of
patches to implement the selftests for this new feature.

--
Kees Cook