Re: [PATCH 12/30] wireless: ath: wil6210: wmi: Correct misnamed function parameter 'ptr_'

From: Lee Jones
Date: Thu Aug 27 2020 - 03:41:07 EST


On Thu, 27 Aug 2020, Lee Jones wrote:

> On Wed, 26 Aug 2020, Kalle Valo wrote:
>
> > Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> >
> > > Fixes the following W=1 kernel build warning(s):
> > >
> > > drivers/net/wireless/ath/wil6210/wmi.c:279: warning: Function parameter or member 'ptr_' not described in 'wmi_buffer_block'
> > > drivers/net/wireless/ath/wil6210/wmi.c:279: warning: Excess function parameter 'ptr' description in 'wmi_buffer_block'
> > >
> > > Cc: Maya Erez <merez@xxxxxxxxxxxxxx>
> > > Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
> > > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> > > Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> > > Cc: linux-wireless@xxxxxxxxxxxxxxx
> > > Cc: wil6210@xxxxxxxxxxxxxxxx
> > > Cc: netdev@xxxxxxxxxxxxxxx
> > > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> >
> > Failed to apply:
> >
> > error: patch failed: drivers/net/wireless/ath/wil6210/wmi.c:266
> > error: drivers/net/wireless/ath/wil6210/wmi.c: patch does not apply
> > stg import: Diff does not apply cleanly
> >
> > Patch set to Changes Requested.
>
> Are you applying them in order?
>
> It may be affected by:
>
> wireless: ath: wil6210: wmi: Fix formatting and demote non-conforming function headers
>
> I'll also rebase onto the latest -next and resubmit.

I just rebased all 3 sets onto the latest -next (next-20200827)
without issue. Not sure what problem you're seeing. Did you apply
the first set before attempting the second?

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog