Re: [PATCH v3 1/1] extcon: ptn5150: Set the VBUS and POLARITY property capability
From: Chanwoo Choi
Date: Thu Aug 27 2020 - 03:59:31 EST
Hi,
On 8/27/20 4:53 PM, Ramuthevar, Vadivel MuruganX wrote:
> Hi,
>
> On 27/8/2020 3:56 pm, Chanwoo Choi wrote:
>> On 8/27/20 3:51 PM, Ramuthevar,Vadivel MuruganX wrote:
>>> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@xxxxxxxxxxxxxxx>
>>>
>>> Set the capability value of property for VBUS and POLARITY.
>>>
>>> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@xxxxxxxxxxxxxxx>
>>> ---
>>> drivers/extcon/extcon-ptn5150.c | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c
>>> index 841c9fe211f1..20d49a54c36e 100644
>>> --- a/drivers/extcon/extcon-ptn5150.c
>>> +++ b/drivers/extcon/extcon-ptn5150.c
>>> @@ -275,6 +275,13 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c)
>>> return ret;
>>> }
>>> + extcon_set_property_capability(info->edev, EXTCON_USB,
>>> + EXTCON_PROP_USB_VBUS);
>>> + extcon_set_property_capability(info->edev, EXTCON_USB_HOST,
>>> + EXTCON_PROP_USB_VBUS);
>>> + extcon_set_property_capability(info->edev, EXTCON_USB_HOST,
>>> + EXTCON_PROP_USB_TYPEC_POLARITY);
>>
>> Above codes used the space for the indentation to keep the vertical line.
>> I think that we better to use tab for the indentation.
>>
>> If there are no objection, I'll fix and then apply it.
> Thank you!, no objection , please fix it.
Applied it. Thanks.
>
> Regards
> Vadivel
>>
>>> +
>>> /* Initialize PTN5150 device and print vendor id and version id */
>>> ret = ptn5150_init_dev_type(info);
>>> if (ret)
>>>
>>
>>
>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics