Re: [PATCH v1 1/2] scsi: ufs: Abort tasks before clear them from doorbell

From: Stanley Chu
Date: Thu Aug 27 2020 - 04:37:32 EST


On Mon, 2020-08-24 at 19:07 -0700, Can Guo wrote:
> To recovery non-fatal errors, no full reset is required, err_handler only
> clears those pending TRs/TMRs so that scsi layer can re-issue them. In
> current err_handler, TRs are directly cleared from UFS host's doorbell but
> not aborted from device side. However, according to the UFSHCI JEDEC spec,
> the host software shall use UTP Transfer Request List CLear Register to
> clear a task from UFS host's doorbell only when a UTP Transfer Request is
> expected to not be completed, e.g. when the host software receives a
> “FUNCTION COMPLETE” Task Management response which means a Transfer Request
> was aborted. To follow the UFSHCI JEDEC spec, in err_handler, aborts one TR
> before clearing it from doorbell.
>
> Signed-off-by: Can Guo <cang@xxxxxxxxxxxxxx>

Acked-by: Stanley Chu <stanley.chu@xxxxxxxxxxxx>