Re: [PATCH v5 1/3] dt-bindings: interrupt-controller: Add Actions SIRQ controller binding

[Marc Zyngier]

On 2020-08-27 11:06, Cristian Ciocaltea wrote:
> On Wed, Aug 26, 2020 at 04:48:38PM -0600, Rob Herring wrote:
> > On Wed, Aug 26, 2020 at 3:42 PM Cristian Ciocaltea
> > <cristian.ciocaltea@xxxxxxxxx> wrote:

[...]

> > Ultimately the GIC trigger type has to be
> > something. Is it fixed or passed thru? If the latter, just use 0
> > (IRQ_TYPE_NONE) if the GIC trigger mode is not fixed. Having some sort
> > of translation of the trigger is pretty common.
>
> Yes, as explained above, the SIRQ controller performs indeed the
> translation of the incoming signal. So if I understand correctly, your
> suggestion would be to use the following inside the sirq node:
>
> interrupts = <GIC_SPI 13 IRQ_TYPE_NONE>, /* SIRQ0 */
>              [...]

Please don't. If you are describing a GIC interrupt, use a
trigger that actually exists. Given that you have a 1:1
mapping between input and output, just encode the output
trigger that matches the input.

        M.
--
Jazz is not dead. It just smells funny...