Re: drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe'

From: Kalle Valo
Date: Thu Aug 27 2020 - 06:46:57 EST


+ linux-wireless

kernel test robot <lkp@xxxxxxxxx> writes:

> Hi Zong-Zhe,
>
> FYI, the error/warning still remains.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 23ee3e4e5bd27bdbc0f1785eef7209ce872794c7
> commit: 72f256c2b948622cc45ff8bc0456dd6039d8fe36 rtw88: extract:
> export symbols about pci interface
> date: 10 weeks ago
> config: arc-randconfig-r026-20200725 (attached as .config)
> compiler: arc-elf-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout 72f256c2b948622cc45ff8bc0456dd6039d8fe36
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
>
> All warnings (new ones prefixed by >>):
>
>>> drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no
>>> previous prototype for 'rtw_pci_probe' [-Wmissing-prototypes]
> 1477 | int rtw_pci_probe(struct pci_dev *pdev,
> | ^~~~~~~~~~~~~
>>> drivers/net/wireless/realtek/rtw88/pci.c:1557:6: warning: no
>>> previous prototype for 'rtw_pci_remove' [-Wmissing-prototypes]
> 1557 | void rtw_pci_remove(struct pci_dev *pdev)
> | ^~~~~~~~~~~~~~
>>> drivers/net/wireless/realtek/rtw88/pci.c:1579:6: warning: no
>>> previous prototype for 'rtw_pci_shutdown' [-Wmissing-prototypes]
> 1579 | void rtw_pci_shutdown(struct pci_dev *pdev)
> | ^~~~~~~~~~~~~~~~

Tony, these are older warnings but please also check these.

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches