Re: [PATCH v36 12/24] x86/sgx: Add SGX_IOC_ENCLAVE_CREATE
From: Borislav Petkov
Date: Thu Aug 27 2020 - 12:15:34 EST
On Thu, Aug 27, 2020 at 04:24:36PM +0300, Jarkko Sakkinen wrote:
> I have not checked if this passes checkpatch.pl yet, but I would
> be surprised if that did not pass (obviously I'll check that).
Right, when you're done with the patchset, just do
checkpatch.pl -g ...
on it before sending and you'll be good to go. Just remember to read the
suggestions checkpatch gives with turned on brain and sanity-check them
instead of blindly following them.
> I'm sorry about that. This was not intentional. I'll revisit them by
> going through all your responses from here:
>
> https://patchwork.kernel.org/patch/11581715/
Actually this one:
https://lkml.kernel.org/r/20200617220844.57423-12-jarkko.sakkinen@xxxxxxxxxxxxxxx
i.e., the v33 version.
Also, make sure you go through the review comments of v34 and v35 in
case you haven't done so yet.
> v34 had the splitting of the big driver patch into multiple patches.
>
> During that process I've obviously failed to address these.
Yeah, that can happen - I mean, this is not even close to being an easy
patchset so thanks for putting in the effort.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette