Re: [PATCH v3 2/3] usb typec: mt6360: Rename driver/Kconfig/Makefile from mt6360 to mt636x

From: Guenter Roeck
Date: Thu Aug 27 2020 - 12:41:37 EST


On Thu, Aug 27, 2020 at 07:18:56PM +0800, cy_huang wrote:
> From: ChiYuan Huang <cy_huang@xxxxxxxxxxx>
>
> 1. Rename file form tcpci_mt6360.c to tcpci_mt636x.c
> 2. Rename internal function from mt6360 to mt636x, except the register
> definition.
> 3. Change Kconfig/Makefile from MT6360 to MT636X.
>
> Signed-off-by: ChiYuan Huang <cy_huang@xxxxxxxxxxx>
> ---
> drivers/usb/typec/tcpm/Kconfig | 6 +-
> drivers/usb/typec/tcpm/Makefile | 2 +-
> drivers/usb/typec/tcpm/tcpci_mt6360.c | 212 ----------------------------------
> drivers/usb/typec/tcpm/tcpci_mt636x.c | 212 ++++++++++++++++++++++++++++++++++
> 4 files changed, 216 insertions(+), 216 deletions(-)
> delete mode 100644 drivers/usb/typec/tcpm/tcpci_mt6360.c
> create mode 100644 drivers/usb/typec/tcpm/tcpci_mt636x.c

Maybe Heikki is ok with this change, but I am not, for the reasons
mentioned before. So I won't approve this patch. Note that, either
case, it should be merged with the first patch.

Guenter