Re: [PATCH 11/23] afs: use ASSERT_FAIL()/ASSERT_WARN() to cleanup some code

From: kernel test robot
Date: Thu Aug 27 2020 - 12:53:57 EST

Hi Chunguang,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on scsi/for-next block/for-next linus/master v5.9-rc2 next-20200827]
[cannot apply to asm-generic/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Chunguang-Xu/clean-up-the-code-related-to-ASSERT/20200827-182148
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: x86_64-randconfig-a012-20200827 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 71f3169e1baeff262583b35ef88f8fb6df7be85e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> fs/afs/callback.c:179:2: error: use of undeclared identifier 'x'
ASSERT(server != NULL);
^
fs/afs/internal.h:1583:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
1 error generated.
--
>> fs/afs/cell.c:130:2: error: use of undeclared identifier 'x'
ASSERT(name);
^
fs/afs/internal.h:1583:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
1 error generated.
--
>> fs/afs/file.c:398:3: error: use of undeclared identifier 'x'
ASSERT(key != NULL);
^
fs/afs/internal.h:1583:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
fs/afs/file.c:553:2: error: use of undeclared identifier 'x'
ASSERT(key != NULL);
^
fs/afs/internal.h:1583:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
2 errors generated.
--
>> fs/afs/flock.c:326:3: error: use of undeclared identifier 'x'
ASSERT(!list_empty(&vnode->granted_locks));
^
fs/afs/internal.h:1583:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
fs/afs/flock.c:591:3: error: use of undeclared identifier 'x'
ASSERT(list_empty(&vnode->granted_locks));
^
fs/afs/internal.h:1583:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
2 errors generated.
--
>> fs/afs/fsclient.c:1224:2: error: use of undeclared identifier 'x'
ASSERT(attr->ia_valid & ATTR_SIZE);
^
fs/afs/internal.h:1583:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
fs/afs/fsclient.c:1266:2: error: use of undeclared identifier 'x'
ASSERT(attr->ia_valid & ATTR_SIZE);
^
fs/afs/internal.h:1583:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
2 errors generated.
--
>> fs/afs/fs_operation.c:138:2: error: use of undeclared identifier 'x'
ASSERT(vnode);
^
fs/afs/internal.h:1583:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
1 error generated.
--
>> fs/afs/mntpt.c:224:2: error: use of undeclared identifier 'x'
ASSERT(list_empty(&afs_vfsmounts));
^
fs/afs/internal.h:1583:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
1 error generated.
--
>> fs/afs/rotate.c:398:2: error: use of undeclared identifier 'x'
ASSERT(op->ac.alist);
^
fs/afs/internal.h:1583:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
1 error generated.
--
>> fs/afs/rxrpc.c:174:3: error: use of undeclared identifier 'x'
ASSERT(!work_pending(&call->async_work));
^
fs/afs/internal.h:1583:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
fs/afs/rxrpc.c:175:3: error: use of undeclared identifier 'x'
ASSERT(call->type->name != NULL);
^
fs/afs/internal.h:1583:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
fs/afs/rxrpc.c:371:2: error: use of undeclared identifier 'x'
ASSERT(call->type != NULL);
^
fs/afs/internal.h:1583:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
fs/afs/rxrpc.c:372:2: error: use of undeclared identifier 'x'
ASSERT(call->type->name != NULL);
^
fs/afs/internal.h:1583:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
4 errors generated.
--
>> fs/afs/server.c:671:2: error: use of undeclared identifier 'x'
ASSERT(server);
^
fs/afs/internal.h:1583:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
1 error generated.
--
>> fs/afs/vl_rotate.c:236:2: error: use of undeclared identifier 'x'
ASSERT(vc->ac.alist);
^
fs/afs/internal.h:1583:31: note: expanded from macro 'ASSERT'
#define ASSERT(X) ASSERT_FAIL(x)
^
1 error generated.

# https://github.com/0day-ci/linux/commit/16d044e9c58d5bce6b15c15a2d4a06c32006837d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Chunguang-Xu/clean-up-the-code-related-to-ASSERT/20200827-182148
git checkout 16d044e9c58d5bce6b15c15a2d4a06c32006837d
vim +/x +179 fs/afs/callback.c

^1da177e4c3f41 Linus Torvalds 2005-04-16 170
^1da177e4c3f41 Linus Torvalds 2005-04-16 171 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 172 * allow the fileserver to break callback promises
^1da177e4c3f41 Linus Torvalds 2005-04-16 173 */
08e0e7c82eeade David Howells 2007-04-26 174 void afs_break_callbacks(struct afs_server *server, size_t count,
5cf9dd55a0ec26 David Howells 2018-04-09 175 struct afs_callback_break *callbacks)
^1da177e4c3f41 Linus Torvalds 2005-04-16 176 {
08e0e7c82eeade David Howells 2007-04-26 177 _enter("%p,%zu,", server, count);
^1da177e4c3f41 Linus Torvalds 2005-04-16 178
08e0e7c82eeade David Howells 2007-04-26 @179 ASSERT(server != NULL);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip