Re: [PATCH] linux/kernel.h: add container_from()
From: Kees Cook
Date: Thu Aug 27 2020 - 13:50:36 EST
On Thu, Aug 27, 2020 at 02:19:41PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Aug 26, 2020 at 07:31:40PM -0700, Kees Cook wrote:
> > On Thu, Aug 27, 2020 at 07:06:36AM +0530, Allen Pais wrote:
> > > Introduce container_from() as a generic helper instead of
> > > sub-systems defining a private from_* API
> > > (Eg: from_tasklets recently introduced in
> > > 12cc923f1ccc: Tasklet: Introduce new initialization API)
> > >
> > > The helper is similar to container_of() in argument order
> > > with the difference of naming the containing structure instead
> > > of having to specify its type.
> > >
> > > Suggested-by: James E.J. Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
> > > Suggested-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > Suggested-by: Jens Axboe <axboe@xxxxxxxxx>
> > > Signed-off-by: Allen Pais <allen.lkml@xxxxxxxxx>
> >
> > Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>
> >
> > Who can carry this so it can get used by multiple trees? Should I keep a
> > git branch folks should merge when taking Allen's conversion patches?
>
> I can put it in my driver core tree, and give everyone a stable, signed,
> tag to pull it from so that it can get propagated everywhere, if that
> makes it easy for others to use it now.
Thank you; that would be lovely. :)
--
Kees Cook