Re: [patch V2 15/46] x86/irq: Consolidate DMAR irq allocation

[Dey, Megha]

Hi Thomas,

On 8/26/2020 1:50 PM, Thomas Gleixner wrote:
> On Wed, Aug 26 2020 at 20:32, Thomas Gleixner wrote:
> > On Wed, Aug 26 2020 at 09:50, Megha Dey wrote:
> > > > @@ -329,15 +329,15 @@ static struct irq_chip dmar_msi_controll
> > > >    static irq_hw_number_t dmar_msi_get_hwirq(struct msi_domain_info *info,
> > > >    					  msi_alloc_info_t *arg)
> > > >    {
> > > > -	return arg->dmar_id;
> > > > +	return arg->hwirq;
> > > Shouldn't this return the arg->devid which gets set in dmar_alloc_hwirq?
> > Indeed.
> But for simplicity we can set arg->hwirq to the dmar id right in the
> alloc function and then once the generic ops are enabled remove the dmar
> callback completely
True, can get rid of more code that way.