Re: [PATCH 7/7] [NOT FOR MERGE] ARM: dts: sun8i: a83t: bananapi-m3: Enable OV8865 camera

From: Kévin L'hôpital
Date: Fri Aug 28 2020 - 03:31:44 EST


Hello,
Le Thu, 27 Aug 2020 17:38:43 +0200,
Maxime Ripard <maxime@xxxxxxxxxx> a écrit :

> Hi,
>
> On Wed, Aug 26, 2020 at 10:58:34AM +0200, Kévin L'hôpital wrote:
> > > > +&ccu {
> > > > + assigned-clocks = <&ccu CLK_CSI_MCLK>;
> > > > + assigned-clock-parents = <&osc24M>;
> > > > + assigned-clock-rates = <24000000>;
> > > > +};
> > >
> > > Why do you need to use assigned-clocks here?
> >
> > I could do it in the ov8865 node, does it sound good to you ?
>
> I mean, it depends on why you want to do it :)
>
> If that's because the sensor expects a clock in a particular clock
> range, then it should be enforced in the sensor driver itself.
>
> Maxime

Yes I will put it in the sensor driver.
Thanks for the answer.
Kévin
--
Kevin L'Hopital, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com