Re: [PATCH 05/14 v5] usb: typec: tcpci: Add set_vbus tcpci callback

From: Greg Kroah-Hartman
Date: Fri Aug 28 2020 - 03:37:08 EST


On Mon, Aug 24, 2020 at 09:22:01PM -0700, Badhri Jagan Sridharan wrote:
> set_vbus callback allows TCPC which are TCPCI based, however,
> does not support turning on sink and source mode through
> Command.SinkVbus and Command.SourceVbusDefaultVoltage.
>
> Signed-off-by: Badhri Jagan Sridharan <badhri@xxxxxxxxxx>
> ---
> drivers/usb/typec/tcpm/tcpci.c | 7 +++++++
> drivers/usb/typec/tcpm/tcpci.h | 1 +
> 2 files changed, 8 insertions(+)

Why is this patch "v5" and the others "v1" in this series?

That's totally confusing, please just version the whole series, not
individual patches, as you are not providing version information about
what changed in this patch, right?

Make it easy for reviewers please...

thanks,

greg k-h