Re: [PATCH v2 3/3] dyndbg: fix problem parsing format="foo bar"
From: Greg KH
Date: Fri Aug 28 2020 - 06:31:31 EST
On Tue, Aug 25, 2020 at 11:33:39AM -0600, Jim Cromie wrote:
> 14775b049642 dyndbg: accept query terms like file=bar and module=foo
>
What does that above line mean???
> That commit broke on a tokenization modality where a word could start
> with a quote, but couldnt continue with one. So the above would
> tokenize as 'format="foo' and 'bar"', and fail hard.
>
> This commit fixes the tokenizer by terminating an unquoted token on
> the '=', avoiding that problem. And since ddebug-parse-query will
> never see a combined 'keyword=value', revert those parts of the
> previous commit.
>
> Signed-off-by: Jim Cromie <jim.cromie@xxxxxxxxx>
Again, a Fixes: tag, and fix up your text above please.
Can you do this and send a v3 of this series and any other pending
dyndbg fixes for 5.9-final?
thanks,
greg k-h