Re: [PATCH v4 1/5] powerpc: Refactor kexec functions to move arch independent code to IMA

[Lakshmi Ramasubramanian]

On 8/27/20 6:23 PM, Thiago Jung Bauermann wrote:
> Lakshmi Ramasubramanian <nramas@xxxxxxxxxxxxxxxxxxx> writes:
>
> > +/**
> > + * ima_get_kexec_buffer - get IMA buffer from the previous kernel
> > + * @addr:	On successful return, set to point to the buffer contents.
> > + * @size:	On successful return, set to the buffer size.
> > + *
> > + * Return: 0 on success, negative errno on error.
> > + */
> > +int ima_get_kexec_buffer(void **addr, size_t *size)
>
> I just noticed that this function is only called from within
> ima_kexec.c, so it can be made static.

Will do.

> > +{
> > +	int ret, len;
> > +	unsigned long tmp_addr;
> > +	size_t tmp_size;
> > +	const void *prop;
> > +
> > +	prop = of_get_property(of_chosen, FDT_PROP_IMA_KEXEC_BUFFER, &len);
> > +	if (!prop)
> > +		return -ENOENT;
> > +
> > +	ret = do_get_kexec_buffer(prop, len, &tmp_addr, &tmp_size);
> > +	if (ret)
> > +		return ret;
> > +
> > +	*addr = __va(tmp_addr);
> > +	*size = tmp_size;
> > +
> > +	return 0;
> > +}
> > +
> > +/**
> > + * ima_free_kexec_buffer - free memory used by the IMA buffer
> > + */
> > +int ima_free_kexec_buffer(void)
>
> This one can be static as well.

Will do.

 -lakshmi

> > +{
> > +	int ret;
> > +	unsigned long addr;
> > +	size_t size;
> > +	struct property *prop;
> > +
> > +	prop = of_find_property(of_chosen, FDT_PROP_IMA_KEXEC_BUFFER, NULL);
> > +	if (!prop)
> > +		return -ENOENT;
> > +
> > +	ret = do_get_kexec_buffer(prop->value, prop->length, &addr, &size);
> > +	if (ret)
> > +		return ret;
> > +
> > +	ret = of_remove_property(of_chosen, prop);
> > +	if (ret)
> > +		return ret;
> > +
> > +	return memblock_free(addr, size);
> > +
> > +}
> > +
> >   #ifdef CONFIG_IMA_KEXEC
> >   static int ima_dump_measurement_list(unsigned long *buffer_size, void **buffer,
> >   				     unsigned long segment_size)