Re: [PATCH v2 08/30] net: wireless: ath: carl9170: Convert 'ar9170_qmap' to inline function

From: Christian Lamparter
Date: Fri Aug 28 2020 - 16:28:51 EST


On Thursday, 27 August 2020 11:33:51 CEST Lee Jones wrote:
> 'ar9170_qmap' is used in some source files which include carl9170.h,
> but not all of them. A 'defined but not used' warning is thrown when
> compiling the ones which do not use it.
>
> Fixes the following W=1 kernel build warning(s)
>
> from drivers/net/wireless/ath/carl9170/carl9170.h:57,
> In file included from drivers/net/wireless/ath/carl9170/carl9170.h:57,
> drivers/net/wireless/ath/carl9170/carl9170.h:71:17: warning: ‘ar9170_qmap’ defined but not used [-Wunused-const-variable=]
>
> NB: Snipped - lots of these repeat
>
> Cc: Christian Lamparter <chunkeey@xxxxxxxxxxxxxx>
> Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx
> Suggested-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---

For what it's worth:
Acked-by: Christian Lamparter <chunkeey@xxxxxxxxx>