Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

From: Ondrej Zary
Date: Fri Aug 28 2020 - 17:34:26 EST


On Friday 28 August 2020 10:59:37 Kalle Valo wrote:
> Ondrej Zary <linux@xxxxxxx> writes:
>
> > On Thursday 27 August 2020 09:49:12 Kalle Valo wrote:
> >> Ondrej Zary <linux@xxxxxxx> writes:
> >>
> >> > On Monday 17 August 2020 20:27:06 Jesse Brandeburg wrote:
> >> >> On Mon, 17 Aug 2020 16:27:01 +0300
> >> >> Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote:
> >> >>
> >> >> > I was surprised to see that someone was using this driver in 2015, so
> >> >> > I'm not sure anymore what to do. Of course we could still just remove
> >> >> > it and later revert if someone steps up and claims the driver is still
> >> >> > usable. Hmm. Does anyone any users of this driver?
> >> >>
> >> >> What about moving the driver over into staging, which is generally the
> >> >> way I understood to move a driver slowly out of the kernel?
> >> >
> >> > Please don't remove random drivers.
> >>
> >> We don't want to waste time on obsolete drivers and instead prefer to
> >> use our time on more productive tasks. For us wireless maintainers it's
> >> really hard to know if old drivers are still in use or if they are just
> >> broken.
> >>
> >> > I still have the Aironet PCMCIA card and can test the driver.
> >>
> >> Great. Do you know if the airo driver still works with recent kernels?
> >
> > Yes, it does.
>
> Nice, I'm very surprised that so old and unmaintained driver still
> works. Thanks for testing.

Thanks to great work of all kernel maintainers most of the old drivers still work so Linux users aren't forced to throw away hardware just because it stopped working after a software update.

--
Ondrej Zary