Re: [PATCH 06/17] virt: acrn: Introduce VM management interfaces

[Shuo A Liu]

Hi Greg,

On Fri 28.Aug'20 at 12:27:38 +0200, Greg Kroah-Hartman wrote:
> On Tue, Aug 25, 2020 at 10:45:06AM +0800, shuo.a.liu@xxxxxxxxx wrote:
> > +	default:
> > +		pr_warn("Unknown IOCTL 0x%x!\n", cmd);
> > +		ret = -EINVAL;
>
> Wrong error value here, right?

Right, it should be -ENOIOCTLCMD.

However, i found many instances in kernel drivers return -EINVAL for no
ioctl command support. :)

> And you just made a simple way to cause a DoS on the kernel log :(

Oh, let me remove the warn log.

Thanks
shuo