Re: [PATCH v3 4/5] fpga manager: xilinx-spi: add error checking after gpiod_get_value()
From: Luca Ceresoli
Date: Sat Aug 29 2020 - 17:08:48 EST
Hi,
On 29/08/20 05:30, kernel test robot wrote:
> Hi Luca,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on v5.9-rc2]
> [also build test WARNING on next-20200828]
> [cannot apply to xlnx/master]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Luca-Ceresoli/fpga-manager-xilinx-spi-remove-stray-comment/20200829-040041
> base: d012a7190fc1fd72ed48911e77ca97ba4521bccd
> compiler: nds32le-linux-gcc (GCC) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
>
>
> cppcheck warnings: (new ones prefixed by >>)
>
>>> drivers/fpga/xilinx-spi.c:183:10: warning: Uninitialized variable: expired [uninitvar]
> while (!expired) {
> ^
Oh dear, Please ignore this patch, v4 will be coming with this fixed.
--
Luca