Re: [PATCH] USB: integrate macro definitions into include/linux/usb.h

[Xu, Yanfei]

I just think it is a clear up to make these macros get togather
which have the samilar attributes. That's why :)

Thanks,
Yanfei

On 8/28/20 3:48 PM, Greg KH wrote:
> On Tue, Aug 25, 2020 at 11:44:21PM +0800, yanfei.xu@xxxxxxxxxxxxx wrote:
> > From: Yanfei Xu <yanfei.xu@xxxxxxxxxxxxx>
> >
> > include/linux/usb.h also contains 'Hard limit' and 'Arbitrary limit'
> > macro definitions in it, hence we can integrate these from config.c
> > into include/linux/usb.h
>
> Why?  No one uses these values outside of this .c file, so why put a
> value in a global .h file?
>
> Who else wants to use these values?  If something else needs it, then
> sure, it could be moved, but until then, there's nothing wrong with the
> existing code as-is from what I can tell.
>
> thanks,
>
> greg k-h