Re: [PATCH v4 2/5] fpga manager: xilinx-spi: remove final dot from dev_err() strings

From: Moritz Fischer
Date: Sun Aug 30 2020 - 20:05:39 EST


On Sun, Aug 30, 2020 at 06:38:47PM +0200, Luca Ceresoli wrote:
> Most dev_err messages in this file have no final dot. Remove the only two
> exceptions to make them consistent.
>
> Reviewed-by: Tom Rix <trix@xxxxxxxxxx>
> Signed-off-by: Luca Ceresoli <luca@xxxxxxxxxxxxxxxx>
>
> ---
>
> Changes in v4:
> - add Reviewed-by Tom Rix
>
> Changes in v3: none.
>
> Changes in v2:
> - move before the "provide better diagnostics on programming failure"
> patch for clarity
> ---
> drivers/fpga/xilinx-spi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/fpga/xilinx-spi.c b/drivers/fpga/xilinx-spi.c
> index 502fae0d1d85..01f494172379 100644
> --- a/drivers/fpga/xilinx-spi.c
> +++ b/drivers/fpga/xilinx-spi.c
> @@ -77,7 +77,7 @@ static int xilinx_spi_write_init(struct fpga_manager *mgr,
> int err;
>
> if (info->flags & FPGA_MGR_PARTIAL_RECONFIG) {
> - dev_err(&mgr->dev, "Partial reconfiguration not supported.\n");
> + dev_err(&mgr->dev, "Partial reconfiguration not supported\n");
> return -EINVAL;
> }
>
> @@ -169,7 +169,7 @@ static int xilinx_spi_write_complete(struct fpga_manager *mgr,
> return xilinx_spi_apply_cclk_cycles(conf);
> }
>
> - dev_err(&mgr->dev, "Timeout after config data transfer.\n");
> + dev_err(&mgr->dev, "Timeout after config data transfer\n");
> return -ETIMEDOUT;
> }
>
> --
> 2.28.0
>
Applied to for-next,

Thanks