Re: [PATCH v3 6/7] arm64: dts: rockchip: px30: Add Engicam C.TOUCH 2.0
From: Johan Jonker
Date: Mon Aug 31 2020 - 06:08:40 EST
Hi Jagan,
A dtsi file with only an include and no changes isn't useful.
Are you planning to add something to it?
Else combine in single dts file for now.
Same for px30-engicam-edimm2.2.dtsi
On 8/31/20 10:29 AM, Jagan Teki wrote:
> Engicam C.TOUCH 2.0 is an EDIMM compliant general purpose
> carrier board with capacitive touch interface.
>
> Genaral features:
> - TFT 10.1" industrial, 1280x800 LVDS display
> - Ethernet 10/100
> - Wifi/BT
> - USB Type A/OTG
> - Audio Out
> - CAN
> - LVDS panel connector
>
> SOM's like PX30.Core needs to mount on top of this Carrier board
> for creating complete PX30.Core C.TOUCH 2.0 board.
>
> Add support for it.
>
> Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Michael Trimarchi <michael@xxxxxxxxxxxxxxxxxxxx>
> ---
> Changes for v3:
> - add Amarula Solutions copyright
> Changes for v2:
> - none
>
> arch/arm64/boot/dts/rockchip/px30-engicam-ctouch2.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
> create mode 100644 arch/arm64/boot/dts/rockchip/px30-engicam-ctouch2.dtsi
>
> diff --git a/arch/arm64/boot/dts/rockchip/px30-engicam-ctouch2.dtsi b/arch/arm64/boot/dts/rockchip/px30-engicam-ctouch2.dtsi
> new file mode 100644
> index 000000000000..58425b1e559f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/px30-engicam-ctouch2.dtsi
> @@ -0,0 +1,8 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2020 Engicam srl
> + * Copyright (c) 2020 Amarula Solutions
> + * Copyright (c) 2020 Amarula Solutions(India)
> + */
> +
> +#include "px30-engicam-common.dtsi"
>