Re: [PATCH] mtd: ck804xrom: fix missing pci device put in error paths

From: Miquel Raynal
Date: Mon Aug 31 2020 - 08:00:40 EST


Hi James,

James Bond <jameslouisebond@xxxxxxxxx> wrote on Fri, 28 Aug 2020
21:28:40 -0500:

> Hi Miquèl,
> Thanks for your feedback.
> I have just rechecked this function and find that "pdev" currently is
> already put
> inside ck804xrom_cleanup, so my previous patch is meaningless...
> The current calling order is like:
>
> window->pdev = pci_dev_get(pdev);
> ...
> ck804xrom_cleanup(window)
> ->
> pci_dev_put(window->pdev);
> And sorry for bothering you.

Ok that's fine, thanks anyway!

Miquèl