Re: [PATCH v2 8/9] frame: Make unwind hints definitions available to other architectures

[Josh Poimboeuf]

On Tue, Aug 25, 2020 at 01:12:04PM +0100, Julien Thierry wrote:
> 
> 
> On 7/30/20 3:56 PM, Josh Poimboeuf wrote:
> > On Thu, Jul 30, 2020 at 10:46:51AM +0100, Julien Thierry wrote:
> > > Unwind hints are useful to provide objtool with information about stack
> > > states in non-standard functions/code.
> > > While the type of information being provided might be very arch
> > > specific, the mechanism to provide the information can be useful for
> > > other architectures.
> > > 
> > > Move the relevant unwint hint definitions for all architectures to
> > > see.
> > 
> > The scope of include/linux/frame.h has been creeping, it's no longer
> > just about frame pointers.  Maybe we should rename it to objtool.h.
> > 
> 
> I missed this comment until now, sorry.
> 
> The name "objtool.h" might conflict with tools/objtool/objtool.h. What about
> "objtool_utils.h" or "objtool_defs.h" ?

There shouldn't be a conflict: objtool doesn't include kernel headers
directly; and even if it did need a copy (in tools/include/linux), it
would be referenced as <linux/objtool.h> instead of "objtool.h".

-- 
Josh