Re: [PATCH] netlink: policy: correct validation type check

From: David Miller
Date: Mon Aug 31 2020 - 15:02:55 EST


From: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
Date: Mon, 31 Aug 2020 20:28:05 +0200

> From: Johannes Berg <johannes.berg@xxxxxxxxx>
>
> In the policy export for binary attributes I erroneously used
> a != NLA_VALIDATE_NONE comparison instead of checking for the
> two possible values, which meant that if a validation function
> pointer ended up aliasing the min/max as negatives, we'd hit
> a warning in nla_get_range_unsigned().
>
> Fix this to correctly check for only the two types that should
> be handled here, i.e. range with or without warn-too-long.
>
> Reported-by: syzbot+353df1490da781637624@xxxxxxxxxxxxxxxxxxxxxxxxx
> Fixes: 8aa26c575fb3 ("netlink: make NLA_BINARY validation more flexible")
> Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>

Applied, thank you.