Re: [linux-next PATCH v3] drivers/virt/fsl_hypervisor: Fix error handling path

[John Hubbard]

On 8/31/20 3:10 PM, Souptick Joarder wrote:
> Hi John,
>
> On Tue, Sep 1, 2020 at 3:38 AM Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote:
> > First, when memory allocation for sg_list_unaligned failed, there
> > is a bug of calling put_pages() as we haven't pinned any pages.
> >
> > Second, if get_user_pages_fast() failed we should unpinned num_pinned
> > pages instead of checking till num_pages.
> >
> > This will address both.
> >
> > As part of these changes, minor update in documentation.
> >
> > Fixes: 6db7199407ca ("drivers/virt: introduce Freescale hypervisor
> > management driver")
> > Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx>
> > Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > Reviewed-by: John Hubbard <jhubbard@xxxxxxxxxx>
>
> Few questions ->
>
> First, there are minor updates from v2 -> v3 other than addressing your
> review comments in v2. Would you like to review it again?

I reviewed it again.

> Second, I think, as per Documentation/core-api/pin_user_pages.rst,
> this is case 5.
> Shall I make the conversion as part of this series ?


Not entirely sure what you mean, but if you just want to add words to the
effect that "this is case 5" to the commit description I certainly don't
see why not. (It would be ideal for a domain expert to weigh in on the
cases here, too.)



thanks,
--
John Hubbard
NVIDIA