Re: [PATCH -next] memory: omap-gpmc: Fix -Wunused-function warnings
From: Yuehaibing
Date: Tue Sep 01 2020 - 02:58:11 EST
On 2020/9/1 14:52, Krzysztof Kozlowski wrote:
> On Tue, Sep 01, 2020 at 11:56:42AM +0800, YueHaibing wrote:
>> drivers/memory/omap-gpmc.c:987:12: warning: ‘gpmc_cs_remap’ defined but not used [-Wunused-function]
>> static int gpmc_cs_remap(int cs, u32 base)
>> ^~~~~~~~~~~~~
>> drivers/memory/omap-gpmc.c:926:20: warning: ‘gpmc_cs_get_name’ defined but not used [-Wunused-function]
>> static const char *gpmc_cs_get_name(int cs)
>> ^~~~~~~~~~~~~~~~
>> drivers/memory/omap-gpmc.c:919:13: warning: ‘gpmc_cs_set_name’ defined but not used [-Wunused-function]
>> static void gpmc_cs_set_name(int cs, const char *name)
>> ^~~~~~~~~~~~~~~~
>> Make them as __maybe_unused to fix this.
>
> Hi,
>
> Do you know what configuration triggers these warnings? What has to be
> disabled (e.g. CONFIG_OF)? Such information is useful in the commit
> message.
Yes, this is triggered by disable CONFIG_OF, I will update the commit log.
>
> Best regards,
> Krzysztof
>
> .
>