Re: [PATCH 11/13] ARM: dts: exynos: Silence SATA PHY warning in Exynos5250 Arndale

[Krzysztof Kozlowski]

On Tue, 1 Sep 2020 at 10:36, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> wrote:

> >>> I'm not against the rename, but frankly, the above node and all i2c
> >>> parameters should be moved to exynos5250.dtsi. This is a SoC internal
> >>> things (the same way as hdmiphy in exynos4.dtsi), so the board dts
> >>> should only contain information like status = "enabled" for i2c_8 and
> >>> hdmi_i2c_phy nodes. No need to duplicate it here and in smdk5250.dts.
> >> Good point, the I2C bus used here is an internal part of SoC.
> >>
> >> I will squash these two changes into a new one. Thanks for the review!
> > While at it, I wonder about the samsung,i2c-slave-addr property. Is it
> > really needed? Are there multiple masters on this bus?
>
> This might be some cargo-cult, probably copied from HDMI DDC (I'm not
> sure if it is needed there). I've removed it and SATA still works fine
> on Exynos5250 Arndale board.

Cool, thanks!

Best regards,
Krzysztof