Re: [01/30] mwifiex: pcie: Move tables to the only place they're used
From: Kalle Valo
Date: Tue Sep 01 2020 - 09:09:15 EST
Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> Saves on 10's of complains about 'defined but not used' variables.
>
> Fixes the following W=1 kernel build warning(s):
>
> In file included from drivers/net/wireless/marvell/mwifiex/main.h:57,
> from drivers/net/wireless/marvell/mwifiex/main.c:22:
> drivers/net/wireless/marvell/mwifiex/pcie.h:310:41: warning: ‘mwifiex_pcie8997’ defined but not used [-Wunused-const-variable=]
> 310 | static const struct mwifiex_pcie_device mwifiex_pcie8997 = {
> | ^~~~~~~~~~~~~~~~
> drivers/net/wireless/marvell/mwifiex/pcie.h:300:41: warning: ‘mwifiex_pcie8897’ defined but not used [-Wunused-const-variable=]
> 300 | static const struct mwifiex_pcie_device mwifiex_pcie8897 = {
> | ^~~~~~~~~~~~~~~~
> drivers/net/wireless/marvell/mwifiex/pcie.h:292:41: warning: ‘mwifiex_pcie8766’ defined but not used [-Wunused-const-variable=]
> 292 | static const struct mwifiex_pcie_device mwifiex_pcie8766 = {
> | ^~~~~~~~~~~~~~~~
>
> NB: Repeats 10's of times - snipped for brevity.
>
> Cc: Amitkumar Karwar <amitkarwar@xxxxxxxxx>
> Cc: Ganapathi Bhat <ganapathi.bhat@xxxxxxx>
> Cc: Xinming Hu <huxinming820@xxxxxxxxx>
> Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
10 patches applied to wireless-drivers-next.git, thanks.
77dacc8fc64c mwifiex: pcie: Move tables to the only place they're used
f5c3bf15f34c brcmsmac: ampdu: Remove a couple set but unused variables
dd13d6dcc24d iwlegacy: 3945-mac: Remove all non-conformant kernel-doc headers
305fd82aee87 iwlegacy: 3945-rs: Remove all non-conformant kernel-doc headers
a60e33af4e28 iwlegacy: 3945: Remove all non-conformant kernel-doc headers
78211e026bd0 brcmfmac: p2p: Fix a couple of function headers
ef8308d34a93 orinoco_usb: Downgrade non-conforming kernel-doc headers
1d2389b53c85 brcmsmac: phy_cmn: Remove a unused variables 'vbat' and 'temp'
2fae7bf8e379 zd1211rw: zd_chip: Fix formatting
f3242a5ba91d zd1211rw: zd_mac: Add missing or incorrect function documentation
--
https://patchwork.kernel.org/patch/11737755/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches