Re: [linux-next PATCH v3] drivers/virt/fsl_hypervisor: Fix error handling path

[John Hubbard]

On 9/1/20 1:14 PM, Souptick Joarder wrote:
> Hi John,
>
> On Tue, Sep 1, 2020 at 4:28 AM John Hubbard <jhubbard@xxxxxxxxxx> wrote:
> > On 8/31/20 3:07 PM, Souptick Joarder wrote:
> > > First, when memory allocation for sg_list_unaligned failed, there
> > > is a bug of calling put_pages() as we haven't pinned any pages.
> >
> > "we should unpin"
>
> will it be "we shouldn't unpin" ? can you please clarify this ?

Whoops, I put my comment next to the wrong part of your email. Sorry
about that! It was supposed to be a correction to this sentence:

"
Second, if get_user_pages_fast() failed we should unpinned num_pinned
pages instead of checking till num_pages.
"

...which I wanted to change to:


Second, if get_user_pages_fast() failed we should unpin num_pinned pages
instead of checking till num_pages.

thanks,
--
John Hubbard
NVIDIA