Re: [PATCH net-next] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

From: Eric Dumazet
Date: Wed Sep 02 2020 - 03:33:00 EST




On 9/1/20 11:34 PM, Yunsheng Lin wrote:

>
> I am not familiar with TCQ_F_CAN_BYPASS.
> From my understanding, the problem is that there is no order between
> qdisc enqueuing and qdisc reset.

Thw qdisc_reset() should be done after rcu grace period, when there is guarantee no enqueue is in progress.

qdisc_destroy() already has a qdisc_reset() call, I am not sure why qdisc_deactivate() is also calling qdisc_reset()