Re: [PATCH 0/2] dma-mapping: update default segment_boundary_mask

From: Niklas Schnelle
Date: Wed Sep 02 2020 - 04:14:25 EST




On 9/2/20 12:16 AM, Nicolin Chen wrote:
> These two patches are to update default segment_boundary_mask.
>
> PATCH-1 fixes overflow issues in callers of dma_get_seg_boundary.
> Previous version was a series: https://lkml.org/lkml/2020/8/31/1026
>
> Then PATCH-2 sets default segment_boundary_mask to ULONG_MAX.
>
> Nicolin Chen (2):
> dma-mapping: introduce dma_get_seg_boundary_nr_pages()
> dma-mapping: set default segment_boundary_mask to ULONG_MAX

I gave both of your patches a quick test ride on a couple of dev mainframes,
both NVMe, ConnectX and virtio-pci devices all seems to work fine.
I already commented on Christoph's mail that I like the helper approach,
so as for s390 you can add my

Acked-by: Niklas Schnelle <schnelle@xxxxxxxxxxxxx>

>
> arch/alpha/kernel/pci_iommu.c | 7 +------
> arch/ia64/hp/common/sba_iommu.c | 3 +--
> arch/powerpc/kernel/iommu.c | 9 ++-------
> arch/s390/pci/pci_dma.c | 6 ++----
> arch/sparc/kernel/iommu-common.c | 10 +++-------
> arch/sparc/kernel/iommu.c | 3 +--
> arch/sparc/kernel/pci_sun4v.c | 3 +--
> arch/x86/kernel/amd_gart_64.c | 3 +--
> drivers/parisc/ccio-dma.c | 3 +--
> drivers/parisc/sba_iommu.c | 3 +--
> include/linux/dma-mapping.h | 21 ++++++++++++++++++++-
> 11 files changed, 34 insertions(+), 37 deletions(-)
>