Re: [PATCH net-next 1/3] dt-bindings: net: Document Broadcom SF2 switch clocks

From: Andrew Lunn
Date: Wed Sep 02 2020 - 08:44:40 EST


On Tue, Sep 01, 2020 at 03:59:11PM -0700, Florian Fainelli wrote:
> Describe the two possible clocks feeding into the Broadcom SF2
> integrated Ethernet switch. BCM7445 systems have two clocks, one for the
> main switch core clock, and another for controlling the switch clock
> divider whereas BCM7278 systems only have the first kind.
>
> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> ---
> .../devicetree/bindings/net/brcm,bcm7445-switch-v4.0.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/brcm,bcm7445-switch-v4.0.txt b/Documentation/devicetree/bindings/net/brcm,bcm7445-switch-v4.0.txt
> index 88b57b0ca1f4..97ca62b0e14d 100644
> --- a/Documentation/devicetree/bindings/net/brcm,bcm7445-switch-v4.0.txt
> +++ b/Documentation/devicetree/bindings/net/brcm,bcm7445-switch-v4.0.txt
> @@ -50,6 +50,13 @@ Optional properties:
> - reset-names: If the "reset" property is specified, this property should have
> the value "switch" to denote the switch reset line.
>
> +- clocks: when provided, the first phandle is to the switch's main clock and
> + is valid for both BCM7445 and BCM7278. The second phandle is only applicable
> + to BCM7445 and is to support dividing the switch core clock.
> +
> +- clock-names: when provided, the first phandle must be "sw_switch", and the
> + second must be named "sw_switch_mdiv".

Hi Florian

Since you look clocks up by name, i don't think the order matters.

Otherwise:

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew