Re: [PATCH 4.19 053/125] media: gpio-ir-tx: improve precision of transmitted signal due to scheduling

[Sean Young]

Hi Pavel,

On Wed, Sep 02, 2020 at 12:25:21PM +0200, Pavel Machek wrote:
> Hi!
> > 
> > [ Upstream commit ea8912b788f8144e7d32ee61e5ccba45424bef83 ]
> > 
> > usleep_range() may take longer than the max argument due to scheduling,
> > especially under load. This is causing random errors in the transmitted
> > IR. Remove the usleep_range() in favour of busy-looping with udelay().
> > 
> > Signed-off-by: Sean Young <sean@xxxxxxxx>
> 
> I don't believe this should be in stable.
> 
> Yes, it probably fixes someone's remote control.
> 
> It also introduces > half a second (!) with interrupts disabled
> (according to the code comments), which will break other devices on
> the system.

Yes, I've always been uncormfortable with this code, but nothing else I
tried worked.

BTW the delay has a maximum of half a second, but the point stands of
course.

> Less intrusive solutions should be explored, first. Like.. if that
> part is time-critical, perhaps it should set itself at realtime
> priority, so that scheduler has motivation to schedule it at the right
> times?

That is an interesting idea, I'll explore that.

> Perhaps usleep_range should be delta, delta+1?

I'm pretty sure I tried that and it didn't work. I'll give it another go.

> Perhaps udelay makes sense to use for more than 10usec?

I don't follow -- what are you suggesting here?

So any other ideas here would be very welcome. I'm happy to explore options,
so far under load the output is can be total garbage if you're unlucky.


Thanks,

Sean


> 
> Best regards,
> 										Pavel
> 
> > @@ -87,13 +87,8 @@ static int gpio_ir_tx(struct rc_dev *dev, unsigned int *txbuf,
> >  			// space
> >  			edge = ktime_add_us(edge, txbuf[i]);
> >  			delta = ktime_us_delta(edge, ktime_get());
> > -			if (delta > 10) {
> > -				spin_unlock_irqrestore(&gpio_ir->lock, flags);
> > -				usleep_range(delta, delta + 10);
> > -				spin_lock_irqsave(&gpio_ir->lock, flags);
> > -			} else if (delta > 0) {
> > +			if (delta > 0)
> >  				udelay(delta);
> > -			}
> >  		} else {
> >  			// pulse
> >  			ktime_t last = ktime_add_us(edge, txbuf[i]);
> > -- 
> > 2.25.1
> > 
> > 
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html