Re: [PATCH] x86/special_insn: reverse __force_order logic

From: peterz
Date: Wed Sep 02 2020 - 08:54:53 EST


On Tue, Sep 01, 2020 at 09:18:57AM -0700, Nadav Amit wrote:

> Unless I misunderstand the logic, __force_order should also be used by
> rdpkru() and wrpkru() which do not have dependency on __force_order. I
> also did not understand why native_write_cr0() has R/W dependency on
> __force_order, and why native_write_cr4() no longer has any dependency
> on __force_order.

There was a fairly large thread about this thing here:

https://lkml.kernel.org/r/20200527135329.1172644-1-arnd@xxxxxxxx

I didn't keep up, but I think the general concensus was that it's
indeed a bit naf.