Re: [PATCH V2 2/2] block: move 'q_usage_counter' into front of 'request_queue'

From: Christoph Hellwig
Date: Wed Sep 02 2020 - 11:41:28 EST

Next message: Johannes Thumshirn: "Re: [PATCH 07/19] swim3: use bdev_check_media_changed"
Previous message: Christoph Hellwig: "Re: [PATCH] x86/uaccess: Use pointer masking to limit uaccess speculation"
In reply to: Ming Lei: "[PATCH V2 2/2] block: move 'q_usage_counter' into front of 'request_queue'"
Next in thread: Jens Axboe: "Re: [PATCH V2 0/2] percpu_ref & block: reduce memory footprint of percpu_ref in fast path"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, Sep 02, 2020 at 08:26:43PM +0800, Ming Lei wrote:
> The field of 'q_usage_counter' is always fetched in fast path of every
> block driver, and move it into front of 'request_queue', so it can be
> fetched into 1st cacheline of 'request_queue' instance.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Next message: Johannes Thumshirn: "Re: [PATCH 07/19] swim3: use bdev_check_media_changed"
Previous message: Christoph Hellwig: "Re: [PATCH] x86/uaccess: Use pointer masking to limit uaccess speculation"
In reply to: Ming Lei: "[PATCH V2 2/2] block: move 'q_usage_counter' into front of 'request_queue'"
Next in thread: Jens Axboe: "Re: [PATCH V2 0/2] percpu_ref & block: reduce memory footprint of percpu_ref in fast path"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]