Re: general protection fault in snd_ctl_release

From: Takashi Iwai
Date: Wed Sep 02 2020 - 11:47:11 EST


On Wed, 02 Sep 2020 17:35:30 +0200,
Al Viro wrote:
>
> On Wed, Sep 02, 2020 at 05:22:00PM +0200, Takashi Iwai wrote:
>
> > Marc, Al, could you guys check this bug?
>
> That's racy; the first one should be get_file_rcu() instead of
> file_count()+get_file(), the second is not needed at all (we
> have the file pinned down by the caller).

Yeah, that wasn't meant as a fix, of course :)


> See vfs.git#work.epoll
> for fix

Thanks! I'll try to run with this fix.


Takashi