Re: [PATCH 5/7] arm64: dts: ti: k3-am65-wakeup: Use generic temperature-sensor for node name

From: Suman Anna
Date: Wed Sep 02 2020 - 12:56:05 EST


On 9/1/20 5:30 PM, Nishanth Menon wrote:
> Use temperature-sensor@ naming for nodes following standard conventions of device
> tree (section 2.2.2 Generic Names recommendation in [1]).
>
> [1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3
>
> Suggested-by: Suman Anna <s-anna@xxxxxx>
> Suggested-by: Vignesh Raghavendra <vigneshr@xxxxxx>
> Signed-off-by: Nishanth Menon <nm@xxxxxx>
> ---
> arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> index bb498be2f0a4..ed42f13e7663 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> @@ -95,7 +95,7 @@
> clock-names = "gpio";
> };
>
> - wkup_vtm0: thermal@42050000 {
> + wkup_vtm0: temperature-sensor@42050000 {

There has been a suggestion to use something like thermal-sensor during the
bindings review, but it is better to use this standard node name.

Reviewed-by: Suman Anna <s-anna@xxxxxx>

regards
Suman

> compatible = "ti,am654-vtm";
> reg = <0x42050000 0x25c>;
> power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>;
>