Re: [PATCH v2 2/2] staging: gdm724x: gdm_tty: replaced macro with a function

[antoni.przybylik@xxxxx]

On 02.09.2020 18:21, Randy Dunlap wrote:
> On 9/2/20 9:16 AM, Antoni Przybylik wrote:
> > Changed return type to bool and removed inline specifier. Also added
> >   static specifier.
> why remove the inline specifier?

Greg KH wrote to me:

And really, no need to make it inline, just make it a normal function
and the compiler will inline it if needed.

> thanks.
>
> > Signed-off-by: Antoni Przybylik <antoni.przybylik@xxxxx>
> > ---
> >   drivers/staging/gdm724x/gdm_tty.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> > index 34a13d98c029..179fc9b9400b 100644
> > --- a/drivers/staging/gdm724x/gdm_tty.c
> > +++ b/drivers/staging/gdm724x/gdm_tty.c
> > @@ -34,7 +34,7 @@ static DEFINE_MUTEX(gdm_table_lock);
> >   static const char *DRIVER_STRING[TTY_MAX_COUNT] = {"GCTATC", "GCTDM"};
> >   static char *DEVICE_STRING[TTY_MAX_COUNT] = {"GCT-ATC", "GCT-DM"};
> >   
> > -inline int gdm_tty_ready(struct gdm *gdm)
> > +static bool gdm_tty_ready(struct gdm *gdm)
> >   {
> >   	return (gdm && gdm->tty_dev && gdm->port.count);
> >   }
Antoni Przybylik